feat: add niquests instrumentation#4459
Open
Ousret wants to merge 1 commit intoopen-telemetry:mainfrom
Open
Conversation
|
|
Ousret
force-pushed
the
instrumentation-niquests
branch
from
64703db to
4946427
Compare
4 tasks
Contributor
|
Hi @Ousret, generally speaking we prefer that library implementors consider adding first-class support for OTel over creating a dedicated instrumentation library. Have you reached out to the library authors to see if they would consider adding OTel instrumentation directly to |
Author
|
I am the maintainer of Niquests. And I am willing to keep an eye into that contribution for the long run. regards, |
Ousret
force-pushed
the
instrumentation-niquests
branch
from
19f9e88 to
d7b80b8
Compare
Ousret
force-pushed
the
instrumentation-niquests
branch
from
d7b80b8 to
aaf5e70
Compare
Author
|
I fixed the CI errors (misc). Regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add OpenTelemetry instrumentation for the niquests (https://niquests.readthedocs.io/) HTTP client library. Niquests is a drop-in replacement for requests with native async support, HTTP/2, HTTP/3, and richer connection metadata. This instrumentation covers both the synchronous Session and the asynchronous AsyncSession interfaces.
Fixes # (issue)
Type of change
How Has This Been Tested?
I heavily inspired myself on other http client instrumentation to build up confidence that this one works too.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.